# Re: \[PATCH net-next v2 2/2\] net: phy: bcm7xxx: Plug in support for reading PHY error counters

- From: Andrew Lunn \<andrew@lunn.ch\>
- Date: 2016-11-29 02:50:26 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/11/11036293
- Thread: https://ratatoskr.run/netdev/2016/11/11036282/t.md

```text
> +struct bcm7xxx_phy_priv {
> +	u64	*stats;
> +};

> +static int bcm7xxx_28nm_probe(struct phy_device *phydev)
> +{
> +	struct bcm7xxx_phy_priv *priv;
> +
> +	priv = devm_kzalloc(&phydev->mdio.dev, sizeof(*priv), GFP_KERNEL);
> +	if (!priv)
> +		return -ENOMEM;
> +
> +	phydev->priv = priv;
> +
> +	priv->stats = devm_kzalloc(&phydev->mdio.dev,
> +				   bcm_phy_get_sset_count(phydev), GFP_KERNEL);

Hi Florian

Should there be a * sizeof(u64) in there?

       Andrew
```