[PATCH iproute2 v2] macsec: Nr. of packets and octets for macsec tx stats were swapped.

Subsystems: the rest

STALE3536d REVIEWED: 4 (3M)

2 review trailers.

2 messages, 2 authors, 2016-11-29 · open the first message on its own page

[PATCH iproute2 v2] macsec: Nr. of packets and octets for macsec tx stats were swapped.

From: <hidden>
Date: 2016-11-23 07:40:38

Resent from other mail address due to our company mail  
[clients|servers] stupidly forcing
line-breaks on plain-text e-mails. Also changed the subject format as  
suggested by Sabrina
and Rami.

Acked-by: Rami Rosen <redacted>
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Daniel Hopf <redacted>
---
  ip/ipmacsec.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c
index c9252bb..aa89a00 100644
--- a/ip/ipmacsec.c
+++ b/ip/ipmacsec.c
@@ -634,10 +634,10 @@ static void print_one_stat(const char **names,  
struct rtattr **attr, int idx,
  }

  static const char *txsc_stats_names[NUM_MACSEC_TXSC_STATS_ATTR] = {
-	[MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutOctetsProtected",
-	[MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutOctetsEncrypted",
-	[MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = "OutPktsProtected",
-	[MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = "OutPktsEncrypted",
+	[MACSEC_TXSC_STATS_ATTR_OUT_PKTS_PROTECTED] = "OutPktsProtected",
+	[MACSEC_TXSC_STATS_ATTR_OUT_PKTS_ENCRYPTED] = "OutPktsEncrypted",
+	[MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_PROTECTED] = "OutOctetsProtected",
+	[MACSEC_TXSC_STATS_ATTR_OUT_OCTETS_ENCRYPTED] = "OutOctetsEncrypted",
  };

  static void print_txsc_stats(const char *prefix, struct rtattr *attr)

Re: [PATCH iproute2 v2] macsec: Nr. of packets and octets for macsec tx stats were swapped.

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-11-29 21:24:57

On Wed, 23 Nov 2016 07:34:31 +0000
daniel.hopf@zebralla-it.de wrote:
Resent from other mail address due to our company mail  
[clients|servers] stupidly forcing
line-breaks on plain-text e-mails. Also changed the subject format as  
suggested by Sabrina
and Rami.

Acked-by: Rami Rosen <redacted>
Acked-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: Daniel Hopf <redacted>
Your mailer still corrupts patches. But since it was trivial I did change manually.
Will show up in next push.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help