[PATCH net-next] net: core: add missing check for uid_range in rule_exists.

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3557d

3 messages, 3 authors, 2016-11-09 · open the first message on its own page

[PATCH net-next] net: core: add missing check for uid_range in rule_exists.

From: Lorenzo Colitti <hidden>
Date: 2016-11-06 15:16:32

Without this check, it is not possible to create two rules that
are identical except for their UID ranges. For example:

root@net-test:/# ip rule add prio 1000 lookup 300
root@net-test:/# ip rule add prio 1000 uidrange 100-200 lookup 300
RTNETLINK answers: File exists
root@net-test:/# ip rule add prio 1000 uidrange 100-199 lookup 100
root@net-test:/# ip rule add prio 1000 uidrange 200-299 lookup 200
root@net-test:/# ip rule add prio 1000 uidrange 300-399 lookup 100
RTNETLINK answers: File exists

Tested: https://android-review.googlesource.com/#/c/299980/
Signed-off-by: Lorenzo Colitti <redacted>
---
 net/core/fib_rules.c | 4 ++++
 1 file changed, 4 insertions(+)
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c
index 5de436a..b6791d9 100644
--- a/net/core/fib_rules.c
+++ b/net/core/fib_rules.c
@@ -343,6 +343,10 @@ static int rule_exists(struct fib_rules_ops *ops, struct fib_rule_hdr *frh,
 		if (r->l3mdev != rule->l3mdev)
 			continue;
 
+		if (!uid_eq(r->uid_range.start, rule->uid_range.start) ||
+		    !uid_eq(r->uid_range.end, rule->uid_range.end))
+			continue;
+
 		if (!ops->compare(r, frh, tb))
 			continue;
 		return 1;
-- 
2.8.0.rc3.226.g39d4020

Re: [PATCH net-next] net: core: add missing check for uid_range in rule_exists.

From: Maciej Żenczykowski <hidden>
Date: 2016-11-07 02:21:23

Acked-by: Maciej Żenczykowski <redacted>

Re: [PATCH net-next] net: core: add missing check for uid_range in rule_exists.

From: David Miller <davem@davemloft.net>
Date: 2016-11-09 18:28:28

From: Lorenzo Colitti <redacted>
Date: Mon,  7 Nov 2016 00:16:25 +0900
Without this check, it is not possible to create two rules that
are identical except for their UID ranges. For example:

root@net-test:/# ip rule add prio 1000 lookup 300
root@net-test:/# ip rule add prio 1000 uidrange 100-200 lookup 300
RTNETLINK answers: File exists
root@net-test:/# ip rule add prio 1000 uidrange 100-199 lookup 100
root@net-test:/# ip rule add prio 1000 uidrange 200-299 lookup 200
root@net-test:/# ip rule add prio 1000 uidrange 300-399 lookup 100
RTNETLINK answers: File exists

Tested: https://android-review.googlesource.com/#/c/299980/
Signed-off-by: Lorenzo Colitti <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help