# Re: \[PATCH net-next 1/2\] firewire: net: fix maximum possible MTU

- From: Jarod Wilson \<hidden\>
- Date: 2016-10-24 01:50:47 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/10/4859535
- Thread: https://ratatoskr.run/netdev/2016/10/4856201/t.md

```text
On Sun, Oct 23, 2016 at 04:29:03PM +0200, Stefan Richter wrote:
> Commit b3e3893e1253 ("net: use core MTU range checking in misc drivers")
> mistakenly introduced an upper limit for firewire-net's MTU based on the
> local link layer controller's reception capability.  Revert this.  Neither
> RFC 2734 nor our implementation impose any particular upper limit.
> 
> Actually, to be on the safe side and to make the code explicit, set
> ETH_MAX_MTU = 65535 as upper limit now.
> 
> (I replaced sizeof(struct rfc2734_header) by the equivalent
> RFC2374_FRAG_HDR_SIZE in order to avoid distracting long/int conversions.)
> 
> Fixes: b3e3893e1253('net: use core MTU range checking in misc drivers')
> CC: <redacted>
> CC: <redacted>
> CC: Jarod Wilson <redacted>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>

Acked-by: Jarod Wilson <redacted>

-- 
Jarod Wilson
jarod@redhat.com
```
