[PATCH -next] rocker: fix error return code in rocker_world_check_init()

From: Wei Yongjun <redacted>

Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/rocker/rocker_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index 2e81b70..0f3265b 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c

@@ -1471,7 +1471,7 @@ static int rocker_world_check_init(struct rocker_port *rocker_port)
 	if (rocker->wops) {
 		if (rocker->wops->mode != mode) {
 			dev_err(&rocker->pdev->dev, "hardware has ports in different worlds, which is not supported\n");
-			return err;
+			return -EINVAL;
 		}
 		return 0;
 	}

Sat, Oct 22, 2016 at 04:31:06PM CEST, weiyj.lk@gmail.com wrote:

From: Wei Yongjun <redacted>

Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>

Fixes: e420114eef4a ("rocker: introduce worlds infrastructure")
Acked-by: Jiri Pirko <redacted>

Dave, you can queue this to -net.

From: Jiri Pirko <jiri@resnulli.us>
Date: Sat, 22 Oct 2016 17:34:29 +0200

Sat, Oct 22, 2016 at 04:31:06PM CEST, weiyj.lk@gmail.com wrote:

quoted

From: Wei Yongjun <redacted>

Fix to return error code -EINVAL from the error handling
case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>

Fixes: e420114eef4a ("rocker: introduce worlds infrastructure")
Acked-by: Jiri Pirko <redacted>

Dave, you can queue this to -net.

Done, thanks.