[PATCH net 1/1] bnx2x: Use the correct divisor value for PHC clock readings.

Subsystems: broadcom bnx2x 10 gigabit ethernet driver, networking drivers, the rest

STALE3603d

2 messages, 2 authors, 2016-10-23 · open the first message on its own page

[PATCH net 1/1] bnx2x: Use the correct divisor value for PHC clock readings.

From: <hidden>
Date: 2016-10-21 06:55:03

From: Sudarsana Reddy Kalluru <redacted>

Time Sync (PTP) implementation uses the divisor/shift value for converting
the clock ticks to nanoseconds. Driver currently defines shift value as 1,
this results in the nanoseconds value to be calculated as half the actual
value. Hence the user application fails to synchronize the device clock
value with the PTP master device clock. Need to use the 'shift' value of 0.

Signed-off-by: Sony.Chacko <redacted>
Signed-off-by: Sudarsana Reddy Kalluru <redacted>
Signed-off-by: Yuval Mintz <redacted>
---
 drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
index 20fe6a8..0cee4c0 100644
--- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
+++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -15241,7 +15241,7 @@ static void bnx2x_init_cyclecounter(struct bnx2x *bp)
 	memset(&bp->cyclecounter, 0, sizeof(bp->cyclecounter));
 	bp->cyclecounter.read = bnx2x_cyclecounter_read;
 	bp->cyclecounter.mask = CYCLECOUNTER_MASK(64);
-	bp->cyclecounter.shift = 1;
+	bp->cyclecounter.shift = 0;
 	bp->cyclecounter.mult = 1;
 }
 
-- 
1.8.3.1

Re: [PATCH net 1/1] bnx2x: Use the correct divisor value for PHC clock readings.

From: David Miller <davem@davemloft.net>
Date: 2016-10-23 21:35:37

From: <redacted>
Date: Fri, 21 Oct 2016 02:09:17 -0400
From: Sudarsana Reddy Kalluru <redacted>

Time Sync (PTP) implementation uses the divisor/shift value for converting
the clock ticks to nanoseconds. Driver currently defines shift value as 1,
this results in the nanoseconds value to be calculated as half the actual
value. Hence the user application fails to synchronize the device clock
value with the PTP master device clock. Need to use the 'shift' value of 0.

Signed-off-by: Sony.Chacko <redacted>
Signed-off-by: Sudarsana Reddy Kalluru <redacted>
Signed-off-by: Yuval Mintz <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help