[patch net] rtnetlink: Add rtnexthop offload flag to compare mask

Subsystems: networking [general], the rest

STALE3610d

3 messages, 3 authors, 2016-10-19 · open the first message on its own page

[patch net] rtnetlink: Add rtnexthop offload flag to compare mask

From: Jiri Pirko <jiri@resnulli.us>
Date: 2016-10-18 16:59:37

From: Jiri Pirko <redacted>

The offload flag is a status flag and should not be used by
FIB semantics for comparison.

Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
Signed-off-by: Jiri Pirko <redacted>
---
Please queue-up to stable as well. Thanks.
---
 include/uapi/linux/rtnetlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 262f037..5a78be5 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h
@@ -350,7 +350,7 @@ struct rtnexthop {
 #define RTNH_F_OFFLOAD		8	/* offloaded route */
 #define RTNH_F_LINKDOWN		16	/* carrier-down on nexthop */
 
-#define RTNH_COMPARE_MASK	(RTNH_F_DEAD | RTNH_F_LINKDOWN)
+#define RTNH_COMPARE_MASK	(RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)
 
 /* Macros to handle hexthops */
 
-- 
2.5.5

Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask

From: Andy Gospodarek <andy@greyhouse.net>
Date: 2016-10-19 02:26:24

On Tue, Oct 18, 2016 at 12:59 PM, Jiri Pirko [off-list ref] wrote:
From: Jiri Pirko <redacted>

The offload flag is a status flag and should not be used by
FIB semantics for comparison.
This is definitely needed.
Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
Signed-off-by: Jiri Pirko <redacted>
Reviewed-by: Andy Gospodarek <andy@greyhouse.net>
quoted hunk
---
Please queue-up to stable as well. Thanks.
---
 include/uapi/linux/rtnetlink.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
index 262f037..5a78be5 100644
--- a/include/uapi/linux/rtnetlink.h
+++ b/include/uapi/linux/rtnetlink.h
@@ -350,7 +350,7 @@ struct rtnexthop {
 #define RTNH_F_OFFLOAD         8       /* offloaded route */
 #define RTNH_F_LINKDOWN                16      /* carrier-down on nexthop */

-#define RTNH_COMPARE_MASK      (RTNH_F_DEAD | RTNH_F_LINKDOWN)
+#define RTNH_COMPARE_MASK      (RTNH_F_DEAD | RTNH_F_LINKDOWN | RTNH_F_OFFLOAD)

 /* Macros to handle hexthops */

--
2.5.5

Re: [patch net] rtnetlink: Add rtnexthop offload flag to compare mask

From: David Miller <davem@davemloft.net>
Date: 2016-10-19 15:08:26

From: Jiri Pirko <jiri@resnulli.us>
Date: Tue, 18 Oct 2016 18:59:34 +0200
From: Jiri Pirko <redacted>

The offload flag is a status flag and should not be used by
FIB semantics for comparison.

Fixes: 37ed9493699c ("rtnetlink: add RTNH_F_EXTERNAL flag for fib offload")
Signed-off-by: Jiri Pirko <redacted>
Ouch, good catch.

Applied and queued up for -stable, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help