[PATCH net-next] net: report right mtu value in error message

Subsystems: networking [general], the rest

STALE3626d

2 messages, 2 authors, 2016-10-17 · open the first message on its own page

[PATCH net-next] net: report right mtu value in error message

From: Jakub Kicinski <hidden>
Date: 2016-10-17 17:02:50

Check is for max_mtu but message reports min_mtu.

Signed-off-by: Jakub Kicinski <redacted>
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 6498cc2ba8f6..352e98129601 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6372,7 +6372,7 @@ int dev_set_mtu(struct net_device *dev, int new_mtu)
 
 	if (dev->max_mtu > 0 && new_mtu > dev->max_mtu) {
 		net_err_ratelimited("%s: Invalid MTU %d requested, hw max %d\n",
-				    dev->name, new_mtu, dev->min_mtu);
+				    dev->name, new_mtu, dev->max_mtu);
 		return -EINVAL;
 	}
 
-- 
1.9.1

Re: [PATCH net-next] net: report right mtu value in error message

From: David Miller <davem@davemloft.net>
Date: 2016-10-17 17:15:46

From: Jakub Kicinski <redacted>
Date: Mon, 17 Oct 2016 18:02:22 +0100
Check is for max_mtu but message reports min_mtu.

Signed-off-by: Jakub Kicinski <redacted>
Good catch, applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help