[patch -next] net: rtnl: info leak in rtnl_fill_vfinfo()

Subsystems: networking [general], the rest

STALE3622d

2 messages, 2 authors, 2016-10-13 · open the first message on its own page

[patch -next] net: rtnl: info leak in rtnl_fill_vfinfo()

From: Dan Carpenter <hidden>
Date: 2016-10-13 08:46:38

The "vf_vlan_info" struct ends with a 2 byte struct hole so we have to
memset it to ensure that no stack information is revealed to user space.

Fixes: 79aab093a0b5 ('net: Update API for VF vlan protocol 802.1ad support')
Signed-off-by: Dan Carpenter <redacted>
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index b06d2f4..fb7348f 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1144,6 +1144,8 @@ static noinline_for_stack int rtnl_fill_vfinfo(struct sk_buff *skb,
 	if (dev->netdev_ops->ndo_get_vf_config(dev, vfs_num, &ivi))
 		return 0;
 
+	memset(&vf_vlan_info, 0, sizeof(vf_vlan_info));
+
 	vf_mac.vf =
 		vf_vlan.vf =
 		vf_vlan_info.vf =

Re: [patch -next] net: rtnl: info leak in rtnl_fill_vfinfo()

From: David Miller <davem@davemloft.net>
Date: 2016-10-13 16:12:29

From: Dan Carpenter <redacted>
Date: Thu, 13 Oct 2016 11:45:28 +0300
The "vf_vlan_info" struct ends with a 2 byte struct hole so we have to
memset it to ensure that no stack information is revealed to user space.

Fixes: 79aab093a0b5 ('net: Update API for VF vlan protocol 802.1ad support')
Signed-off-by: Dan Carpenter <redacted>
Applied, thanks Dan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help