Re: [PATCH v2] net: fec: set mac address unconditionally
From: David Miller <davem@davemloft.net>
Date: 2016-10-03 05:28:06
From: David Miller <davem@davemloft.net>
Date: 2016-10-03 05:28:06
From: Gavin Schenk <redacted> Date: Fri, 30 Sep 2016 11:46:10 +0200
If the mac address origin is not dt, you can only safely assign a mac
address after "link up" of the device. If the link is off the clocks are
disabled and because of issues assigning registers when clocks are off the
new mac address cannot be written in .ndo_set_mac_address() on some soc's.
This fix sets the mac address unconditionally in fec_restart(...) and
ensures consistency between fec registers and the network layer.
Signed-off-by: Gavin Schenk <redacted>
Acked-by: Fugang Duan <redacted>
Acked-by: Uwe Kleine-König <redacted>
Fixes: 9638d19e4816 ("net: fec: add netif status check before set mac address")
---
Changes since (implicit) v1:
- reword commit log as suggested by Uwe
- added AcksApplied and queued up for -stable, thanks.