[PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock

Subsystems: networking drivers, the rest

STALE3671d

2 messages, 2 authors, 2016-10-03 · open the first message on its own page

[PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock

From: Alexey Khoroshilov <hidden>
Date: 2016-09-30 21:56:59

There is no need to clk_disable_unprepare(dev->clk)
before it was initialized.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <redacted>
---
 drivers/net/ethernet/marvell/mvmdio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/marvell/mvmdio.c b/drivers/net/ethernet/marvell/mvmdio.c
index 8982c882af1b..a0d1b084ecec 100644
--- a/drivers/net/ethernet/marvell/mvmdio.c
+++ b/drivers/net/ethernet/marvell/mvmdio.c
@@ -211,8 +211,7 @@ static int orion_mdio_probe(struct platform_device *pdev)
 	dev->regs = devm_ioremap(&pdev->dev, r->start, resource_size(r));
 	if (!dev->regs) {
 		dev_err(&pdev->dev, "Unable to remap SMI register\n");
-		ret = -ENODEV;
-		goto out_mdio;
+		return -ENODEV;
 	}
 
 	init_waitqueue_head(&dev->smi_busy_wait);
-- 
2.7.4

Re: [PATCH] net: mvmdio: do not clk_disable_unprepare() NULL clock

From: David Miller <davem@davemloft.net>
Date: 2016-10-03 06:04:02

From: Alexey Khoroshilov <redacted>
Date: Sat,  1 Oct 2016 00:56:37 +0300
There is no need to clk_disable_unprepare(dev->clk)
before it was initialized.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help