Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

3 messages, 3 authors, 2016-09-26 · open the first message on its own page

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

From: Kalle Valo <hidden>
Date: 2016-09-26 18:01:30

SF Markus Elfring [off-list ref] writes:
quoted
9291771 [2/3] hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()
9291775 [3/3] hostap: Delete unnecessary initialisations for the variable "ret"

Reason: The benefit is not clear.
How do you think about to reduce the source code a bit at these places?
hostap is an obsolete driver, it's waste of time doing style fixes to it
as nobody maintains it anymore.

-- 
Kalle Valo

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

From: SF Markus Elfring <hidden>
Date: 2016-09-26 18:06:49

hostap is an obsolete driver, it's waste of time doing style fixes to it
as nobody maintains it anymore.
Thanks for another bit of your software development attention and this information.

Is it easier to understand than the previous response "Reason: The benefit is not clear."?

Regards,
Markus

Re: hostap: Delete an unnecessary jump label in prism2_ioctl_priv_hostapd()

From: Joe Perches <joe@perches.com>
Date: 2016-09-26 18:18:12

On Mon, 2016-09-26 at 21:01 +0300, Kalle Valo wrote:
hostap is an obsolete driver, it's waste of time doing style fixes to it
as nobody maintains it anymore.
Dunno know if Jouni is still maintaining this at all
but maybe a MAINTAINERS update to mark it obsolete so
checkpatch warns on unnecessary changes.
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 6e0a912c3b13..ff293e70fae6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5722,7 +5722,7 @@ M:	Jouni Malinen 
 L:	hostap@shmoo.com (subscribers-only)
 L:	linux-wireless@vger.kernel.org
 W:	http://hostap.epitest.fi/
-S:	Maintained
+S:	Maintained / Obsolete
 F:	drivers/net/wireless/intersil/hostap/
 
 HP COMPAQ TC1100 TABLET WMI EXTRAS DRIVER
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help