[PATCH] net: r6040: add in missing white space in error message text

Subsystems: networking drivers, rdc r6040 fast ethernet driver, the rest

STALE3683d

2 messages, 2 authors, 2016-09-12 · open the first message on its own page

[PATCH] net: r6040: add in missing white space in error message text

From: Colin King <hidden>
Date: 2016-09-12 12:10:27

From: Colin Ian King <redacted>

A couple of dev_err messages span two lines and the literal
string is missing a white space between words. Add the white
space.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/rdc/r6040.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index cb29ee2..5dc655b 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	/* this should always be supported */
 	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
 	if (err) {
-		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
 				"not supported by the card\n");
 		goto err_out_disable_dev;
 	}
 	err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
 	if (err) {
-		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
 				"not supported by the card\n");
 		goto err_out_disable_dev;
 	}
-- 
2.9.3

Re: [PATCH] net: r6040: add in missing white space in error message text

From: Sergei Shtylyov <hidden>
Date: 2016-09-12 13:06:05

Hello.

On 9/12/2016 3:08 PM, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

A couple of dev_err messages span two lines and the literal
string is missing a white space between words. Add the white
space.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/net/ethernet/rdc/r6040.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/rdc/r6040.c b/drivers/net/ethernet/rdc/r6040.c
index cb29ee2..5dc655b 100644
--- a/drivers/net/ethernet/rdc/r6040.c
+++ b/drivers/net/ethernet/rdc/r6040.c
@@ -1062,13 +1062,13 @@ static int r6040_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 	/* this should always be supported */
 	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
 	if (err) {
-		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
 				"not supported by the card\n");
 		goto err_out_disable_dev;
 	}
 	err = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
 	if (err) {
-		dev_err(&pdev->dev, "32-bit PCI DMA addresses"
+		dev_err(&pdev->dev, "32-bit PCI DMA addresses "
 				"not supported by the card\n");
 		goto err_out_disable_dev;
 	}
   The message strings simply shouldn't be broken up, and checkpatch.pl knows about that.

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help