[PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

Subsystems: atm, the rest

STALE3682d

3 messages, 2 authors, 2016-09-12 · open the first message on its own page

[PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

From: Colin King <hidden>
Date: 2016-09-12 09:31:02 

From: Colin Ian King <redacted>

The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and remove trailing white space.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/atm/iphase.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..256b191 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
                 if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {     
                     return ret;
                 }
-       } 
-	else  
-           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn"); 
+	} else
+		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");
         
         iadev->testTable[vcc->vci]->vc_status |= VC_ACTIVE;
 	IF_EVENT(printk("ia open_tx returning \n");)  
-- 
2.9.3

Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

From: Sergei Shtylyov <hidden>
Date: 2016-09-12 11:55:21 

Hello.

On 9/12/2016 12:29 PM, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and remove trailing white space.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/atm/iphase.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..256b191 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
                 if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
                     return ret;
                 }
-       }
-	else
-           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn");
+	} else
+		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");
   All branches of the *if* statement should have {} if at least one has them, perhaps a material for a follow-up patch).

[...]

MBR, Sergei

Re: [PATCH] atm: iphase: fix newline escape and minor tweak to source formatting

From: Sergei Shtylyov <hidden>
Date: 2016-09-12 11:55:28 

Hello.

On 9/12/2016 12:29 PM, Colin King wrote:
quoted hunk
From: Colin Ian King <redacted>

The newline escape is incorrect and needs fixing. Also adjust source
formatting / indentation and remove trailing white space.

Signed-off-by: Colin Ian King <redacted>
---
 drivers/atm/iphase.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/atm/iphase.c b/drivers/atm/iphase.c
index 9d8807e..256b191 100644
--- a/drivers/atm/iphase.c
+++ b/drivers/atm/iphase.c
@@ -1885,9 +1885,8 @@ static int open_tx(struct atm_vcc *vcc)
                 if ((ret = ia_cbr_setup (iadev, vcc)) < 0) {
                     return ret;
                 }
-       }
-	else
-           printk("iadev:  Non UBR, ABR and CBR traffic not supportedn");
+	} else
+		printk("iadev:  Non UBR, ABR and CBR traffic not supported\n");
   All branches of the *if* statement should have {} if at least one has them (perhaps a material for a follow-up patch).

[...]

MBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help