From: Eric Dumazet <hidden> Date: 2016-09-01 16:43:41
On Mon, 2016-08-29 at 09:32 -0400, robert.foss@collabora.com wrote:
From: Robert Foss <redacted>
From: Grant Grundler <redacted>
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler <redacted>
Signed-off-by: Robert Foss <redacted>
Tested-by: Robert Foss <redacted>
---
This is _really_ confusing Robert.
Why having two 'From:' clauses ?
Who wrote the patch in the first place ? You or Grant ?
End result is :
commit 535baf8588d04b177cb33700f81499f2b5203c2d
Author: Robert Foss [off-list ref]
Date: Mon Aug 29 09:32:19 2016 -0400
net: asix: autoneg will set WRITE_MEDIUM reg
From: Grant Grundler [off-list ref]
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler [off-list ref]
Signed-off-by: Robert Foss [off-list ref]
Tested-by: Robert Foss [off-list ref]
Signed-off-by: David S. Miller [off-list ref]
I guess Grant wrote the patch, but attribution is wrong.
From: Robert Foss <hidden> Date: 2016-09-01 16:47:42
On 2016-09-01 12:43 PM, Eric Dumazet wrote:
On Mon, 2016-08-29 at 09:32 -0400, robert.foss@collabora.com wrote:
quoted
From: Robert Foss <redacted>
From: Grant Grundler <redacted>
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler <redacted>
Signed-off-by: Robert Foss <redacted>
Tested-by: Robert Foss <redacted>
---
This is _really_ confusing Robert.
Why having two 'From:' clauses ?
Who wrote the patch in the first place ? You or Grant ?
I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.
Would you like me to resubmit in v++ and make sure that it has been
corrected?
End result is :
commit 535baf8588d04b177cb33700f81499f2b5203c2d
Author: Robert Foss [off-list ref]
Date: Mon Aug 29 09:32:19 2016 -0400
net: asix: autoneg will set WRITE_MEDIUM reg
From: Grant Grundler [off-list ref]
The miii_nway_restart() causes a PHY link change activity and
ax88772_link_reset will be called. link_reset will set
AX_CMD_WRITE_MEDIUM_MODE register correctly.
The asix_write_medium_mode in reset() fills in a default value to the register
which may be different from the negotiation result. So do this first.
Ignore the ret value since it's ignored in XXX_link_reset() functions.
Signed-off-by: Grant Grundler [off-list ref]
Signed-off-by: Robert Foss [off-list ref]
Tested-by: Robert Foss [off-list ref]
Signed-off-by: David S. Miller [off-list ref]
I guess Grant wrote the patch, but attribution is wrong.
From: Eric Dumazet <hidden> Date: 2016-09-01 21:02:37
On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.
Would you like me to resubmit in v++ and make sure that it has been
corrected?
This is too late, patches are already merged in David Miller net-next
tree.
These kinds of errors can not be fixed, we have to be very careful at
submission/review time.
I guess Grant does not care, but some contributors, especially new ones
would like to get proper attribution.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Grant Grundler <hidden> Date: 2016-09-06 16:42:04
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet [off-list ref] wrote:
On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
quoted
I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.
Would you like me to resubmit in v++ and make sure that it has been
corrected?
This is too late, patches are already merged in David Miller net-next
tree.
These kinds of errors can not be fixed, we have to be very careful at
submission/review time.
I guess Grant does not care, but some contributors, especially new ones
would like to get proper attribution.
I do not mind. Robert will get email about bugs instead of me. :D
cheers,
grant
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Robert Foss <hidden> Date: 2016-09-06 21:48:31
On 2016-09-06 12:41 PM, Grant Grundler wrote:
On Thu, Sep 1, 2016 at 10:02 AM, Eric Dumazet [off-list ref] wrote:
quoted
On Thu, 2016-09-01 at 12:47 -0400, Robert Foss wrote:
quoted
I'm not quite sure how the first From line was added, it
should not have been.
Grant Grundler is most definitely the author.
Would you like me to resubmit in v++ and make sure that it has been
corrected?
This is too late, patches are already merged in David Miller net-next
tree.
These kinds of errors can not be fixed, we have to be very careful at
submission/review time.
I guess Grant does not care, but some contributors, especially new ones
would like to get proper attribution.
I do not mind. Robert will get email about bugs instead of me. :D