Re: [PATCH v5 00/16] Add Paravirtual RDMA Driver

On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote:

quoted

As Jason said, you need a very good reason to split and create number of
files per-driver in UAPI folder.

I can move the pvrdma-uapi.h back to the pvrdma driver folder.

Just don't copy any of the content into your user space provider.

Thanks
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote:

On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote:

quoted

quoted

As Jason said, you need a very good reason to split and create number of
files per-driver in UAPI folder.

I can move the pvrdma-uapi.h back to the pvrdma driver folder.

Just don't copy any of the content into your user space provider.

Thanks. I wanted to clarify regarding device specific structures since that
is what our pvrdma-uapi.h file has.

Wouldnt they be some overlap between the user-space and kernel driver? Or is
it expected that the common structures (even device specific ones) be moved to
the ABI file?

For the mlx4 driver I see that the structures in include/linux/mlx4/qp.h
and in libmlx4/src/wqe.h are similar.

Thanks,
Adit