[PATCH net] net/mlx4_core: Fix to clean devlink resources

Subsystems: mellanox mlx4 core vpi driver, networking drivers, the rest

STALE3678d

2 messages, 2 authors, 2016-09-22 · open the first message on its own page

[PATCH net] net/mlx4_core: Fix to clean devlink resources

From: Tariq Toukan <hidden>
Date: 2016-09-20 11:56:31

From: Kamal Heib <redacted>

This patch cleans devlink resources by calling devlink_port_unregister()
to avoid the following issues:

- Kernel panic when triggering reset flow.
- Memory leak due to unfreed resources in mlx4_init_port_info().

Fixes: 09d4d087cd48 ("mlx4: Implement devlink interface")
Signed-off-by: Kamal Heib <redacted>
Signed-off-by: Tariq Toukan <redacted>
---
Please push it to -stable  >= 4.6 as well. Thanks.

 drivers/net/ethernet/mellanox/mlx4/main.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 75dd2e3d3059..7183ac4135d2 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2970,6 +2970,7 @@ static int mlx4_init_port_info(struct mlx4_dev *dev, int port)
 		mlx4_err(dev, "Failed to create mtu file for port %d\n", port);
 		device_remove_file(&info->dev->persist->pdev->dev,
 				   &info->port_attr);
+		devlink_port_unregister(&info->devlink_port);
 		info->port = -1;
 	}
 
@@ -2984,6 +2985,8 @@ static void mlx4_cleanup_port_info(struct mlx4_port_info *info)
 	device_remove_file(&info->dev->persist->pdev->dev, &info->port_attr);
 	device_remove_file(&info->dev->persist->pdev->dev,
 			   &info->port_mtu_attr);
+	devlink_port_unregister(&info->devlink_port);
+
 #ifdef CONFIG_RFS_ACCEL
 	free_irq_cpu_rmap(info->rmap);
 	info->rmap = NULL;
-- 
1.8.3.1

Re: [PATCH net] net/mlx4_core: Fix to clean devlink resources

From: David Miller <davem@davemloft.net>
Date: 2016-09-22 05:41:46

From: Tariq Toukan <redacted>
Date: Tue, 20 Sep 2016 14:55:31 +0300
From: Kamal Heib <redacted>

This patch cleans devlink resources by calling devlink_port_unregister()
to avoid the following issues:

- Kernel panic when triggering reset flow.
- Memory leak due to unfreed resources in mlx4_init_port_info().

Fixes: 09d4d087cd48 ("mlx4: Implement devlink interface")
Signed-off-by: Kamal Heib <redacted>
Signed-off-by: Tariq Toukan <redacted>
---
Please push it to -stable  >= 4.6 as well. Thanks.
Applied and queued up for -stable, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help