# Re: \[v2 PATCH 0/2\] rhashtable: rhashtable with duplicate objects

- From: Herbert Xu \<herbert@gondor.apana.org.au\>
- Date: 2016-09-19 10:48:13 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/09/11029440
- Thread: https://ratatoskr.run/netdev/2016/09/11029439/t.md

```text
On Mon, Sep 19, 2016 at 12:10:27PM +0200, Johannes Berg wrote:
> Btw, for debug I put
> 
> BUG_ON(atomic_read(&ht->nelems) < 0);
> 
> after the atomic_dec() in __rhashtable_remove_fast_one(). That makes
> the kernel crash instantly on the buggy code, and I just have to run a
> single test ("wpas_ctrl_interface_add_many") to get there.

Aha I see the problem now.  The nelems logic on remove is broken.
I'll send out a v3.

Thanks!
-- 
Email: Herbert Xu [ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
```