[PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()

Subsystems: cxgb4 ethernet driver (cxgb4), networking drivers, the rest

STALE3679d

2 messages, 2 authors, 2016-09-19 · open the first message on its own page

[PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()

From: Wei Yongjun <hidden>
Date: 2016-09-17 15:52:26

From: Wei Yongjun <redacted>

Fix the retrn value check which testing the wrong variable
in cfg_queues_uld().

Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of
resources for ULD")
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 5d402ba..4d1de62 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -245,7 +245,7 @@ int cfg_queues_uld(struct adapter *adap, unsigned int uld_type,
 	}
 
 	rxq_info->rspq_id = kcalloc(nrxq, sizeof(unsigned short), GFP_KERNEL);
-	if (!rxq_info->uldrxq) {
+	if (!rxq_info->rspq_id) {
 		kfree(rxq_info->uldrxq);
 		kfree(rxq_info);
 		return -ENOMEM;

Re: [PATCH -next] cxgb4: Fix return value check in cfg_queues_uld()

From: David Miller <davem@davemloft.net>
Date: 2016-09-19 05:42:52

From: Wei Yongjun <redacted>
Date: Sat, 17 Sep 2016 15:52:17 +0000
From: Wei Yongjun <redacted>

Fix the retrn value check which testing the wrong variable
in cfg_queues_uld().

Fixes: 94cdb8bb993a ("cxgb4: Add support for dynamic allocation of
resources for ULD")
Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help