[PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning

Subsystems: broadcom b53/sf2 ethernet switch driver, networking drivers, networking [dsa], the rest

STALE3683d

3 messages, 3 authors, 2016-09-16 · open the first message on its own page

[PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning

From: Wei Yongjun <hidden>
Date: 2016-09-15 02:24:24

From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/dsa/bcm_sf2.c:963:19: warning:
 symbol 'bcm_sf2_io_ops' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/dsa/bcm_sf2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index 51f1fc0..f8bb5a5 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -960,7 +960,7 @@ static int bcm_sf2_core_write64(struct b53_device *dev, u8 page, u8 reg,
 	return 0;
 }
 
-struct b53_io_ops bcm_sf2_io_ops = {
+static struct b53_io_ops bcm_sf2_io_ops = {
 	.read8	= bcm_sf2_core_read8,
 	.read16	= bcm_sf2_core_read16,
 	.read32	= bcm_sf2_core_read32,

Re: [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2016-09-15 02:46:50

2016-09-14 19:24 GMT-07:00 Wei Yongjun [off-list ref]:
From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/dsa/bcm_sf2.c:963:19: warning:
 symbol 'bcm_sf2_io_ops' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH -next] net: dsa: bcm_sf2: Fix non static symbol warning

From: David Miller <davem@davemloft.net>
Date: 2016-09-16 08:26:13

From: Wei Yongjun <redacted>
Date: Thu, 15 Sep 2016 02:24:13 +0000
From: Wei Yongjun <redacted>

Fixes the following sparse warning:

drivers/net/dsa/bcm_sf2.c:963:19: warning:
 symbol 'bcm_sf2_io_ops' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help