RE: [PATCH v4 01/16] vmxnet3: Move PCI Id to pci_ids.h

On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:

Please update vmxnet3_drv.c accordingly.

Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved
PCI device id from pci_ids.h file.

- Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote:

On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:

quoted

Please update vmxnet3_drv.c accordingly.

Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved
PCI device id from pci_ids.h file.

So now you need to include it from vmxnet3_drv.c.
Same with pvrdma_main.c

- Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote:

On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote:

quoted

On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:

quoted

Please update vmxnet3_drv.c accordingly.

Any reason why? I don't think we need to. Vmxnet3 should just pick up
the moved PCI device id from pci_ids.h file.

So now you need to include it from vmxnet3_drv.c.
Same with pvrdma_main.c

If you're asking me to include pci_ids.h in our drivers we already do that
by including pci.h in both the drivers. 
pci.h already includes pci_ids.h - 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/pci.h#n35

If that's going to change maybe someone from the PCI group can comment on.

Thanks,
Adit

Besides that no more comments.

Reviewed-by: Yuval Shaia <redacted>

On Wed, Sep 14, 2016 at 07:36:34PM +0000, Adit Ranadive wrote:

On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote:

quoted

On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote:

quoted

On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:

quoted

Please update vmxnet3_drv.c accordingly.

Any reason why? I don't think we need to. Vmxnet3 should just pick up
the moved PCI device id from pci_ids.h file.

So now you need to include it from vmxnet3_drv.c.
Same with pvrdma_main.c

If you're asking me to include pci_ids.h in our drivers we already do that
by including pci.h in both the drivers. 
pci.h already includes pci_ids.h - 
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/linux/pci.h#n35

If that's going to change maybe someone from the PCI group can comment on.

Thanks,
Adit
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html