Re: [RFC 03/11] Add support for RoCE HW init

3 messages, 3 authors, 2016-09-19 · open the first message on its own page

Re: [RFC 03/11] Add support for RoCE HW init

From: Sagi Grimberg <hidden>
Date: 2016-09-13 14:38:13

+	dev->max_sge = min_t(u32, RDMA_MAX_SGE_PER_SQ_WQE,
+			     RDMA_MAX_SGE_PER_RQ_WQE);
Our kernel target mode consumers sort of rely on max_sge_rd, you need
to make sure to set it too.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [RFC 03/11] Add support for RoCE HW init

From: Amrani, Ram <hidden>
Date: 2016-09-14 10:13:24

quoted
+	dev->max_sge = min_t(u32, RDMA_MAX_SGE_PER_SQ_WQE,
+			     RDMA_MAX_SGE_PER_RQ_WQE);
Our kernel target mode consumers sort of rely on max_sge_rd, you need to
make sure to set it too.
Good catch. Thanks!

RE: [RFC 03/11] Add support for RoCE HW init

From: Amrani, Ram <hidden>
Date: 2016-09-19 08:45:50

quoted
quoted
+	dev->max_sge = min_t(u32, RDMA_MAX_SGE_PER_SQ_WQE,
+			     RDMA_MAX_SGE_PER_RQ_WQE);
Our kernel target mode consumers sort of rely on max_sge_rd, you need
to make sure to set it too.
Good catch. Thanks!
Actually, as I come to code this, I just realized that max_sge_rd is already set in the  query verb itself:

+int qedr_query_device(struct ib_device *ibdev,
+                     struct ib_device_attr *attr, struct ib_udata *udata)
+{

<snip>

+       attr->max_sge = qattr->max_sge;
+       attr->max_sge_rd = qattr->max_sge;

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help