[PATCH net-next] ip_tunnel: do not clear l4 hashes

Subsystems: networking [general], networking [ipv4/ipv6], the rest

STALE3687d

2 messages, 2 authors, 2016-09-10 · open the first message on its own page

[PATCH net-next] ip_tunnel: do not clear l4 hashes

From: Eric Dumazet <hidden>
Date: 2016-09-08 22:40:51

From: Eric Dumazet <redacted>

If skb has a valid l4 hash, there is no point clearing hash and force
a further flow dissection when a tunnel encapsulation is added.

Signed-off-by: Eric Dumazet <redacted>
---
 net/ipv4/ip_tunnel_core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
index 0f227db0e9ac..777bc1883870 100644
--- a/net/ipv4/ip_tunnel_core.c
+++ b/net/ipv4/ip_tunnel_core.c
@@ -69,7 +69,7 @@ void iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb,
 
 	skb_scrub_packet(skb, xnet);
 
-	skb_clear_hash(skb);
+	skb_clear_hash_if_not_l4(skb);
 	skb_dst_set(skb, &rt->dst);
 	memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
 

Re: [PATCH net-next] ip_tunnel: do not clear l4 hashes

From: David Miller <davem@davemloft.net>
Date: 2016-09-10 02:35:35

From: Eric Dumazet <redacted>
Date: Thu, 08 Sep 2016 15:40:48 -0700
From: Eric Dumazet <redacted>

If skb has a valid l4 hash, there is no point clearing hash and force
a further flow dissection when a tunnel encapsulation is added.

Signed-off-by: Eric Dumazet <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help