From: Eric Dumazet <hidden> Date: 2016-09-08 04:52:59
From: Eric Dumazet <redacted>
In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
ancillary data") Francesco added IP_TOS values specified as integer.
However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
in a single byte, when IP_RECVTOS is set on the socket.
It can be very useful to reflect all ancillary options as given by the
kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
EINVAL after Francesco patch.
So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
server can simply reuse same ancillary block without having to mangle
it.
Jesper can then augment
https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
to add TOS reflection ;)
Fixes: f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data")
Signed-off-by: Eric Dumazet <redacted>
Cc: Francesco Fusco <redacted>
Cc: Jesper Dangaard Brouer <redacted>
---
net/ipv4/ip_sockglue.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
On Wed, 07 Sep 2016 21:52:56 -0700
Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <redacted>
In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
ancillary data") Francesco added IP_TOS values specified as integer.
However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
in a single byte, when IP_RECVTOS is set on the socket.
It can be very useful to reflect all ancillary options as given by the
kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
EINVAL after Francesco patch.
So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
server can simply reuse same ancillary block without having to mangle
it.
Jesper can then augment
https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
to add TOS reflection ;)
This is actually your old program ;-)
Do I need to change anything, as I'm just bouncing the packet back with sendmsg() ?
Fixes: f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data")
Signed-off-by: Eric Dumazet <redacted>
Cc: Francesco Fusco <redacted>
Cc: Jesper Dangaard Brouer <redacted>
Looks like a good fix,
Acked-by: Jesper Dangaard Brouer <redacted>
From: Eric Dumazet <hidden> Date: 2016-09-08 13:31:16
On Thu, 2016-09-08 at 11:15 +0200, Jesper Dangaard Brouer wrote:
On Wed, 07 Sep 2016 21:52:56 -0700
Eric Dumazet [off-list ref] wrote:
quoted
From: Eric Dumazet <redacted>
In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
ancillary data") Francesco added IP_TOS values specified as integer.
However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
in a single byte, when IP_RECVTOS is set on the socket.
It can be very useful to reflect all ancillary options as given by the
kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
EINVAL after Francesco patch.
So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
server can simply reuse same ancillary block without having to mangle
it.
Jesper can then augment
https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
to add TOS reflection ;)
This is actually your old program ;-)
Do I need to change anything, as I'm just bouncing the packet back with sendmsg() ?
I guess you want to add an option and if this option is requested by the
user, add :
setsockopt(fd, SOL_IP, IP_PKTINFO, &on, sizeof(on));
+ if (tos_reflect)
+ setsockopt(fd, SOL_IP, IP_RECVTOS, &on, sizeof(on));
before the loop doing the recvmsg()/sendmsg() calls.
Thanks !
From: Eric Dumazet <redacted>
In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
ancillary data") Francesco added IP_TOS values specified as integer.
However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
in a single byte, when IP_RECVTOS is set on the socket.
It can be very useful to reflect all ancillary options as given by the
kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
EINVAL after Francesco patch.
So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
server can simply reuse same ancillary block without having to mangle
it.
Jesper can then augment
https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
to add TOS reflection ;)
Fixes: f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as ancillary data")
Signed-off-by: Eric Dumazet <redacted>
On Thu, 08 Sep 2016 06:31:14 -0700
Eric Dumazet [off-list ref] wrote:
On Thu, 2016-09-08 at 11:15 +0200, Jesper Dangaard Brouer wrote:
quoted
On Wed, 07 Sep 2016 21:52:56 -0700
Eric Dumazet [off-list ref] wrote:
quoted
From: Eric Dumazet <redacted>
In commit f02db315b8d8 ("ipv4: IP_TOS and IP_TTL can be specified as
ancillary data") Francesco added IP_TOS values specified as integer.
However, kernel sends to userspace (at recvmsg() time) an IP_TOS value
in a single byte, when IP_RECVTOS is set on the socket.
It can be very useful to reflect all ancillary options as given by the
kernel in a subsequent sendmsg(), instead of aborting the sendmsg() with
EINVAL after Francesco patch.
So this patch extends IP_TOS ancillary to accept an u8, so that an UDP
server can simply reuse same ancillary block without having to mangle
it.
Jesper can then augment
https://github.com/netoptimizer/network-testing/blob/master/src/udp_example02.c
to add TOS reflection ;)
This is actually your old program ;-)
Do I need to change anything, as I'm just bouncing the packet back with sendmsg() ?
I guess you want to add an option and if this option is requested by the
user, add :
setsockopt(fd, SOL_IP, IP_PKTINFO, &on, sizeof(on));
+ if (tos_reflect)
+ setsockopt(fd, SOL_IP, IP_RECVTOS, &on, sizeof(on));
before the loop doing the recvmsg()/sendmsg() calls.