[PATCH net-next] macsec: set network devtype

STALE3688d

4 messages, 3 authors, 2016-09-09 · open the first message on its own page

[PATCH net-next] macsec: set network devtype

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-09-07 21:07:23

The netdevice type structure for macsec was being defined but never used.
To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
Compile tested only, I don't use macsec.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/drivers/net/macsec.c	2016-08-25 17:20:20.671031972 -0700
+++ b/drivers/net/macsec.c	2016-09-07 14:03:01.676238097 -0700
@@ -2973,6 +2973,7 @@ static void macsec_setup(struct net_devi
 	dev->priv_flags |= IFF_NO_QUEUE;
 	dev->netdev_ops = &macsec_netdev_ops;
 	dev->destructor = macsec_free_netdev;
+	SET_NETDEV_DEVTYPE(dev, &macsec_type);
 
 	eth_zero_addr(dev->broadcast);
 }

Re: [PATCH net-next] macsec: set network devtype

From: David Miller <davem@davemloft.net>
Date: 2016-09-09 00:24:08

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 14:07:32 -0700
The netdevice type structure for macsec was being defined but never used.
To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
Compile tested only, I don't use macsec.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Sabrina, please review.

Thanks.

Re: [PATCH net-next] macsec: set network devtype

From: Sabrina Dubroca <sd@queasysnail.net>
Date: 2016-09-09 15:54:39

2016-09-08, 17:24:07 -0700, David Miller wrote:
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 14:07:32 -0700
quoted
The netdevice type structure for macsec was being defined but never used.
To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
Compile tested only, I don't use macsec.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Sabrina, please review.

Thanks.
Sorry for the delay. LGTM:

Acked-by: Sabrina Dubroca <sd@queasysnail.net>

-- 
Sabrina

Re: [PATCH net-next] macsec: set network devtype

From: David Miller <davem@davemloft.net>
Date: 2016-09-09 23:53:13

From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 14:07:32 -0700
The netdevice type structure for macsec was being defined but never used.
To set the network device type the macro SET_NETDEV_DEVTYPE must be called.
Compile tested only, I don't use macsec.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help