This structure is defined but never used. Flagged with W=1
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
--- a/net/core/rtnetlink.c 2016-09-07 13:55:17.030107744 -0700
+++ b/net/core/rtnetlink.c 2016-09-07 13:55:45.190236855 -0700
@@ -3669,10 +3669,6 @@ nla_put_failure:
return -EMSGSIZE;
}
-static const struct nla_policy ifla_stats_policy[IFLA_STATS_MAX + 1] = {
- [IFLA_STATS_LINK_64] = { .len = sizeof(struct rtnl_link_stats64) },
-};
-
static size_t if_nlmsg_stats_size(const struct net_device *dev,
u32 filter_mask)
{From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 13:57:36 -0700
This structure is defined but never used. Flagged with W=1
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
("rtnetlink: add new RTM_GETSTATS message to dump link stats")
Roopa, did you intentionally put this here unreferenced for the
purposes or documentation or something like that?
On 9/8/16, 5:23 PM, David Miller wrote:
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Wed, 7 Sep 2016 13:57:36 -0700
quoted
This structure is defined but never used. Flagged with W=1
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
This comes from commit 10c9ead9f3c6bb24bddc9a96681f7d58e6623966
("rtnetlink: add new RTM_GETSTATS message to dump link stats")
Roopa, did you intentionally put this here unreferenced for the
purposes or documentation or something like that?
I went back and looked at all my submissions to remember why i had it.
I don't seem to have used it anywhere...but i had expressed an intent to use
it to parse filter attributes in incoming stats requests in my first few versions.
I possibly just forgot to drop it after i moved to a mask to filter incoming stats requests.
thanks for checking...
Acked-by: Roopa Prabhu <redacted>
and thanks stephen for cleaning this up.