[PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

Subsystems: networking [general], networking [ipsec], the rest

STALE3693d

4 messages, 3 authors, 2016-09-08 · open the first message on its own page

[PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

From: Subash Abhinov Kasiviswanathan <hidden>
Date: 2016-09-07 00:10:24

proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
proc_douintvec allows to write upto UINT_MAX.

Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>
---
 net/xfrm/xfrm_sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/xfrm/xfrm_sysctl.c b/net/xfrm/xfrm_sysctl.c
index 05a6e3d..35a7e79 100644
--- a/net/xfrm/xfrm_sysctl.c
+++ b/net/xfrm/xfrm_sysctl.c
@@ -17,13 +17,13 @@ static struct ctl_table xfrm_table[] = {
 		.procname	= "xfrm_aevent_etime",
 		.maxlen		= sizeof(u32),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_douintvec
 	},
 	{
 		.procname	= "xfrm_aevent_rseqth",
 		.maxlen		= sizeof(u32),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec
+		.proc_handler	= proc_douintvec
 	},
 	{
 		.procname	= "xfrm_larval_drop",
-- 
1.9.1

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

From: David Miller <davem@davemloft.net>
Date: 2016-09-08 00:25:19

From: Subash Abhinov Kasiviswanathan <redacted>
Date: Tue,  6 Sep 2016 18:09:31 -0600
proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
proc_douintvec allows to write upto UINT_MAX.

Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>
I am assuming Steffen will pick this up.

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

From: David Miller <davem@davemloft.net>
Date: 2016-09-08 06:27:24

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 8 Sep 2016 07:51:17 +0200
On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote:
quoted
From: Subash Abhinov Kasiviswanathan <redacted>
Date: Tue,  6 Sep 2016 18:09:31 -0600
quoted
proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
proc_douintvec allows to write upto UINT_MAX.

Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>
I am assuming Steffen will pick this up.
proc_douintvec is not in the ipsec-next tree. The ipsec-next
tree is currently based on net-next from Aug 9. The patch
that introduces proc_douintvec came in on Aug 25.

I can take it after the pull request for ipsec-next, that
I plan to do today. Alternatively, you can take it directly
into net-next. It does not interfere anything that I
have in ipsec-next. In case you want to take it directly:

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Ok, I've applied it to net-next then, thanks!

Re: [PATCH net-next] net: xfrm: Change u32 sysctl entries to use proc_douintvec

From: Steffen Klassert <steffen.klassert@secunet.com>
Date: 2016-09-08 06:51:26

On Wed, Sep 07, 2016 at 05:25:18PM -0700, David Miller wrote:
From: Subash Abhinov Kasiviswanathan <redacted>
Date: Tue,  6 Sep 2016 18:09:31 -0600
quoted
proc_dointvec limits the values to INT_MAX in u32 sysctl entries.
proc_douintvec allows to write upto UINT_MAX.

Signed-off-by: Subash Abhinov Kasiviswanathan <redacted>
I am assuming Steffen will pick this up.
proc_douintvec is not in the ipsec-next tree. The ipsec-next
tree is currently based on net-next from Aug 9. The patch
that introduces proc_douintvec came in on Aug 25.

I can take it after the pull request for ipsec-next, that
I plan to do today. Alternatively, you can take it directly
into net-next. It does not interfere anything that I
have in ipsec-next. In case you want to take it directly:

Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help