[PATCH net-next] openvswitch: Free tmpl with tmpl_free.

Subsystems: networking [general], openvswitch, the rest

STALE3697d

2 messages, 2 authors, 2016-09-04 · open the first message on its own page

[PATCH net-next] openvswitch: Free tmpl with tmpl_free.

From: Joe Stringer <hidden>
Date: 2016-09-02 01:01:59

When an error occurs during conntrack template creation as part of
actions validation, we need to free the template. Previously we've been
using nf_ct_put() to do this, but nf_ct_tmpl_free() is more appropriate.

Signed-off-by: Joe Stringer <redacted>
---
 net/openvswitch/conntrack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
index e054a748ff25..31045ef44a82 100644
--- a/net/openvswitch/conntrack.c
+++ b/net/openvswitch/conntrack.c
@@ -1367,7 +1367,7 @@ static void __ovs_ct_free_action(struct ovs_conntrack_info *ct_info)
 	if (ct_info->helper)
 		module_put(ct_info->helper->me);
 	if (ct_info->ct)
-		nf_ct_put(ct_info->ct);
+		nf_ct_tmpl_free(ct_info->ct);
 }
 
 void ovs_ct_init(struct net *net)
-- 
2.9.3

Re: [PATCH net-next] openvswitch: Free tmpl with tmpl_free.

From: David Miller <davem@davemloft.net>
Date: 2016-09-04 18:38:29

From: Joe Stringer <redacted>
Date: Thu,  1 Sep 2016 18:01:47 -0700
When an error occurs during conntrack template creation as part of
actions validation, we need to free the template. Previously we've been
using nf_ct_put() to do this, but nf_ct_tmpl_free() is more appropriate.

Signed-off-by: Joe Stringer <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help