[PATCH -next] net: phy: Fix return value check in xgmiitorgmii_probe()

Subsystems: ethernet phy library, networking drivers, the rest

STALE3670d

2 messages, 2 authors, 2016-08-15 · open the first message on its own page

[PATCH -next] net: phy: Fix return value check in xgmiitorgmii_probe()

From: Wei Yongjun <hidden>
Date: 2016-08-15 22:34:57

In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/phy/xilinx_gmii2rgmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
index 8e980ad..cad6e19 100644
--- a/drivers/net/phy/xilinx_gmii2rgmii.c
+++ b/drivers/net/phy/xilinx_gmii2rgmii.c
@@ -67,7 +67,7 @@ int xgmiitorgmii_probe(struct mdio_device *mdiodev)
 		return -ENOMEM;
 
 	phy_node = of_parse_phandle(np, "phy-handle", 0);
-	if (IS_ERR(phy_node)) {
+	if (!phy_node) {
 		dev_err(dev, "Couldn't parse phy-handle\n");
 		return -ENODEV;
 	}

[PATCH -next] net: phy: Fix return value check in xgmiitorgmii_probe()

From: davem@davemloft.net (David Miller)
Date: 2016-08-15 23:34:43

From: Wei Yongjun <redacted>
Date: Mon, 15 Aug 2016 22:34:57 +0000
In case of error, the function of_parse_phandle() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help