From: Caesar Wang <hidden> Date: 2016-08-31 23:29:52
This patch add to handle the gmac pd, and support
the rk3399 gmac for devicetree.
The History version:
v1: https://lkml.org/lkml/2016/8/30/668
v2: https://lkml.org/lkml/2016/8/31/27
Changes in v3:
- leave into two patches based on patchv2, and fix nits and commit, as
comment on https://patchwork.kernel.org/patch/9306339/
- generate a patch from https://patchwork.kernel.org/patch/9306339/.
Changes in v2:
- rk_gmac_powerup instead of the rk_gmac_init.
- fixes the build error on next kernel.
- Fixes the order, ss Heiko commnets on
https://patchwork.kernel.org/patch/9305991/
Caesar Wang (3):
arm64: dts: rockchip: add the gmac power domain on rk3399
arm64: dts: rockchip: add the gmac needed node for rk3399
arm64: dts: rockchip: enable the gmac for rk3399 evb board
David Wu (1):
net: stmmac: dwmac-rk: add pd_gmac support for rk3399
Roger Chen (1):
net: stmmac: dwmac-rk: fixes the gmac resume after PD on/off
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31 +++++++++
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 90 ++++++++++++++++++++++++++
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 28 +++++---
3 files changed, 140 insertions(+), 9 deletions(-)
--
1.9.1
From: Caesar Wang <hidden> Date: 2016-08-31 23:29:44
From: David Wu <redacted>
Add the gmac power domain support for rk3399, in order to save more
power consumption.
Signed-off-by: David Wu <redacted>
Signed-off-by: Caesar Wang <redacted>
---
Changes in v3: None
Changes in v2:
- fixes the build error on next kernel.
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 9 +++++++++
1 file changed, 9 insertions(+)
From: Caesar Wang <hidden> Date: 2016-08-31 23:29:48
From: Roger Chen <redacted>
GMAC Power Domain(PD) will be disabled during suspend.
That will causes GRF registers reset.
So corresponding GRF registers for GMAC must be setup again.
Signed-off-by: Roger Chen <redacted>
Signed-off-by: Caesar Wang <redacted>
---
Changes in v3: None
Changes in v2:
- rk_gmac_powerup instead of the rk_gmac_init.
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 19 ++++++++++---------
1 file changed, 10 insertions(+), 9 deletions(-)
From: Caesar Wang <hidden> Date: 2016-08-31 23:29:55
This patch supports the gmac pd to save power consumption.
Even though some boards not need Ethernet support, the driver
core can also take care of powering up the pd before probe.
Signed-off-by: Roger Chen <redacted>
Signed-off-by: Caesar Wang <redacted>
---
Changes in v3:
- leave into two patches based on patchv2, and fix nits and commit, as
comment on https://patchwork.kernel.org/patch/9306339/
Changes in v2:
- Fixes the order, ss Heiko commnets on
https://patchwork.kernel.org/patch/9305991/
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
@@ -739,6 +744,11 @@};/* These power domains are grouped by VD_LOGIC */+pd_gmac@RK3399_PD_GMAC{+reg=<RK3399_PD_GMAC>;+clocks=<&cruACLK_GMAC>;+pm_qos=<&qos_gmac>;+};pd_vio@RK3399_PD_VIO{reg=<RK3399_PD_VIO>;#address-cells=<1>;
From: Caesar Wang <hidden> Date: 2016-08-31 23:31:18
The RK3399 GMAC Ethernet Controller provides a complete Ethernet interface
from processor to a Reduced Media Independent Interface (RMII) and Reduced
Gigabit Media Independent Interface (RGMII) compliant Ethernet PHY.
This patch adds the related needed device information.
e.g.: interrupts, grf, clocks, pinctrl and so on.
The full details are in [0].
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Caesar Wang <redacted>
---
Changes in v3:
- generate a patch from https://patchwork.kernel.org/patch/9306339/.
Changes in v2: None
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 80 ++++++++++++++++++++++++++++++++
1 file changed, 80 insertions(+)
From: Caesar Wang <hidden> Date: 2016-08-31 23:31:20
We add the required and optional properties for evb board.
See the [0] to get the detail information.
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Roger Chen <redacted>
Signed-off-by: Caesar Wang <redacted>
---
Changes in v3: None
Changes in v2: None
arch/arm64/boot/dts/rockchip/rk3399-evb.dts | 31 +++++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
Hi Caesar,
Am Donnerstag, 1. September 2016, 07:28:51 schrieb Caesar Wang:
The RK3399 GMAC Ethernet Controller provides a complete Ethernet interface
from processor to a Reduced Media Independent Interface (RMII) and Reduced
Gigabit Media Independent Interface (RGMII) compliant Ethernet PHY.
This patch adds the related needed device information.
e.g.: interrupts, grf, clocks, pinctrl and so on.
The full details are in [0].
[0]:
Documentation/devicetree/bindings/net/rockchip-dwmac.txt
Signed-off-by: Caesar Wang <redacted>
the core rk3399 gmac support is still stuck and needs a respin. This patch is
part of that other series as well which needs a respin itself.
Maybe you could just fold both series into one so that we don't have to track
two.
Thanks
Heiko
Hi Caesar,
Am Donnerstag, 1. September 2016, 07:28:50 schrieb Caesar Wang:
This patch supports the gmac pd to save power consumption.
Even though some boards not need Ethernet support, the driver
core can also take care of powering up the pd before probe.
Signed-off-by: Roger Chen <redacted>
Signed-off-by: Caesar Wang <redacted>
who is the author of this patch? Roger or you? Because we should either drop
Roger's Signed-off or fix the authorship to list him.
Heiko
@@ -739,6 +744,11 @@};/* These power domains are grouped by VD_LOGIC */+pd_gmac@RK3399_PD_GMAC{+reg=<RK3399_PD_GMAC>;+clocks=<&cruACLK_GMAC>;+pm_qos=<&qos_gmac>;+};pd_vio@RK3399_PD_VIO{reg=<RK3399_PD_VIO>;#address-cells=<1>;
From: Caesar Wang <hidden> Date: 2016-09-01 17:53:37
On 2016年09月01日 19:41, Heiko Stübner wrote:
Hi Caesar,
Am Donnerstag, 1. September 2016, 07:28:50 schrieb Caesar Wang:
quoted
This patch supports the gmac pd to save power consumption.
Even though some boards not need Ethernet support, the driver
core can also take care of powering up the pd before probe.
Signed-off-by: Roger Chen <redacted>
Signed-off-by: Caesar Wang <redacted>
who is the author of this patch? Roger or you? Because we should either drop
Roger's Signed-off or fix the authorship to list him.
@@ -739,6 +744,11 @@};/* These power domains are grouped by VD_LOGIC */+pd_gmac@RK3399_PD_GMAC{+reg=<RK3399_PD_GMAC>;+clocks=<&cruACLK_GMAC>;+pm_qos=<&qos_gmac>;+};pd_vio@RK3399_PD_VIO{reg=<RK3399_PD_VIO>;#address-cells=<1>;