[PATCH net] net: bgmac: fix reversed check for MII registration error

Subsystems: broadcom iproc gbit ethernet driver, networking drivers, the rest

STALE3667d

2 messages, 2 authors, 2016-08-19 · open the first message on its own page

[PATCH net] net: bgmac: fix reversed check for MII registration error

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2016-08-17 13:38:03

From: Rafał Miłecki <rafal@milecki.pl>

It was failing on successful registration returning meaningless errors.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
---
This fix is intendent for net repository (4.8 release).
---
 drivers/net/ethernet/broadcom/bgmac-bcma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/broadcom/bgmac-bcma.c b/drivers/net/ethernet/broadcom/bgmac-bcma.c
index 9a9745c4..625235d 100644
--- a/drivers/net/ethernet/broadcom/bgmac-bcma.c
+++ b/drivers/net/ethernet/broadcom/bgmac-bcma.c
@@ -159,7 +159,7 @@ static int bgmac_probe(struct bcma_device *core)
 
 	if (!bgmac_is_bcm4707_family(core)) {
 		mii_bus = bcma_mdio_mii_register(core, bgmac->phyaddr);
-		if (!IS_ERR(mii_bus)) {
+		if (IS_ERR(mii_bus)) {
 			err = PTR_ERR(mii_bus);
 			goto err;
 		}
-- 
1.8.4.5

Re: [PATCH net] net: bgmac: fix reversed check for MII registration error

From: David Miller <davem@davemloft.net>
Date: 2016-08-19 06:25:53

From: Rafał Miłecki <zajec5@gmail.com>
Date: Wed, 17 Aug 2016 15:37:14 +0200
From: Rafał Miłecki <rafal@milecki.pl>

It was failing on successful registration returning meaningless errors.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Fixes: 55954f3bfdac ("net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file")
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help