[PATCH 0710/1285] Replace numeric parameter like 0444 with macro
From: Baole Ni <hidden>
Date: 2016-08-02 16:12:48
Also in:
lkml
Subsystem:
brocade bna 10 gigabit ethernet driver, networking drivers, the rest · Maintainers:
Rasesh Mody, Sudarsana Kalluru, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/ethernet/brocade/bna/bnad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c b/drivers/net/ethernet/brocade/bna/bnad.c
index 771cc26..0d1f6e8 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c@@ -38,11 +38,11 @@ static DEFINE_MUTEX(bnad_fwimg_mutex); * Module params */ static uint bnad_msix_disable; -module_param(bnad_msix_disable, uint, 0444); +module_param(bnad_msix_disable, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bnad_msix_disable, "Disable MSIX mode"); static uint bnad_ioc_auto_recover = 1; -module_param(bnad_ioc_auto_recover, uint, 0444); +module_param(bnad_ioc_auto_recover, uint, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(bnad_ioc_auto_recover, "Enable / Disable auto recovery"); static uint bna_debugfs_enable = 1;
--
2.9.2