[PATCH 0738/1285] Replace numeric parameter like 0444 with macro
DORMANTno replies
From: Baole Ni <hidden>
Date: 2016-08-02 16:02:26
Also in:
lkml
Subsystem:
networking drivers, sis 900/7016 fast ethernet driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Daniele Venzano, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/ethernet/sis/sis900.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sis/sis900.c b/drivers/net/ethernet/sis/sis900.c
index 95001ee4..96eef0d 100644
--- a/drivers/net/ethernet/sis/sis900.c
+++ b/drivers/net/ethernet/sis/sis900.c@@ -197,9 +197,9 @@ MODULE_AUTHOR("Jim Huang <cmhuang@sis.com.tw>, Ollie Lho <ollie@sis.com.tw>"); MODULE_DESCRIPTION("SiS 900 PCI Fast Ethernet driver"); MODULE_LICENSE("GPL"); -module_param(multicast_filter_limit, int, 0444); -module_param(max_interrupt_work, int, 0444); -module_param(sis900_debug, int, 0444); +module_param(multicast_filter_limit, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(max_interrupt_work, int, S_IRUSR | S_IRGRP | S_IROTH); +module_param(sis900_debug, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of filtered multicast addresses"); MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled per interrupt"); MODULE_PARM_DESC(sis900_debug, "SiS 900/7016 bitmapped debugging message level");
--
2.9.2