[PATCH 1132/1285] Replace numeric parameter like 0444 with macro

DORMANTno replies

From: Baole Ni <hidden>
Date: 2016-08-02 13:56:36
Also in: linux-rdma, lkml
Subsystem: networking [general], rds - reliable datagram sockets, the rest · Maintainers: "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Allison Henderson, Linus Torvalds

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <redacted>
Signed-off-by: Baole Ni <redacted>
---
 net/rds/send.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/rds/send.c b/net/rds/send.c
index b1962f8..8d2fe20 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -53,7 +53,7 @@
  * drained the queue).
  */
 static int send_batch_count = SZ_1K;
-module_param(send_batch_count, int, 0444);
+module_param(send_batch_count, int, S_IRUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(send_batch_count, " batch factor when working the send queue");
 
 static void rds_send_remove_from_sock(struct list_head *messages, int status);
-- 
2.9.2
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help