[PATCH 0760/1285] Replace numeric parameter like 0444 with macro
From: Baole Ni <hidden>
Date: 2016-08-02 12:25:11
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/wimax/i2400m/driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wimax/i2400m/driver.c b/drivers/net/wimax/i2400m/driver.c
index 9c78090..42eb711 100644
--- a/drivers/net/wimax/i2400m/driver.c
+++ b/drivers/net/wimax/i2400m/driver.c@@ -77,7 +77,7 @@ static char i2400m_debug_params[128]; module_param_string(debug, i2400m_debug_params, sizeof(i2400m_debug_params), - 0644); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(debug, "String of space-separated NAME:VALUE pairs, where NAMEs " "are the different debug submodules and VALUE are the "
@@ -85,7 +85,7 @@ MODULE_PARM_DESC(debug, static char i2400m_barkers_params[128]; module_param_string(barkers, i2400m_barkers_params, - sizeof(i2400m_barkers_params), 0644); + sizeof(i2400m_barkers_params), S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(barkers, "String of comma-separated 32-bit values; each is " "recognized as the value the device sends as a reboot "
--
2.9.2