[PATCH 0754/1285] Replace numeric parameter like 0444 with macro
DORMANTno replies
From: Baole Ni <hidden>
Date: 2016-08-02 12:21:55
Also in:
lkml
Subsystem:
networking drivers, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu <redacted> Signed-off-by: Baole Ni <redacted> --- drivers/net/vxlan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index f999db2..ffc540f 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c@@ -63,11 +63,11 @@ * for compatibility with early adopters. */ static unsigned short vxlan_port __read_mostly = 8472; -module_param_named(udp_port, vxlan_port, ushort, 0444); +module_param_named(udp_port, vxlan_port, ushort, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(udp_port, "Destination UDP port"); static bool log_ecn_error = true; -module_param(log_ecn_error, bool, 0644); +module_param(log_ecn_error, bool, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(log_ecn_error, "Log packets received with corrupted ECN"); static int vxlan_net_id;
--
2.9.2