On Fri, 2016-07-22 at 14:26 +0900, Masashi Honma wrote:
On 2016年07月14日 05:07, Yaniv Machani wrote:
quoted
+
+ /* if channel width is 20MHz - configure HT capab
accordingly*/
+ if (sdata->vif.bss_conf.chandef.width ==
NL80211_CHAN_WIDTH_20) {
+ cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+ cap &= ~IEEE80211_HT_CAP_DSSSCCK40;
+ }
I have tested this part of your patch and this works for me.
Previouly, "Supported Channel Width Set bit" in HT Capabilities
element was 1 even though disable_ht40=1 existed in
wpa_supplicant.conf. After appllication of patch, the bit was 0.
But why is that behaviour *correct*? We still support 40 MHz bandwidth
things, we just don't use them if we disable HT40.
johannes
On 2016年08月01日 19:03, Johannes Berg wrote:
But why is that behaviour *correct*? We still support 40 MHz bandwidth
things, we just don't use them if we disable HT40.
I could not fully understand your concern...
Do you mean we have 2 bugs about disabling HT40 ?
1) bits in HT capabilities IE
2) HT40 still enabled even if it was disabled by wpa_supplicant or
hostapd with disable_ht40
And do you mean 1) and 2) should be fixed at one time ?
Indeed, currently on the view point of opposite peer, HT40 was enabled
even though it was disabled because both 1) and 2) are wrong.
But if only 1) was fixed, this causes unmatch.
Now I do not recognize bug 2).
Do you have any information about 2) ?
On 2016年08月01日 19:03, Johannes Berg wrote:
quoted
But why is that behaviour *correct*? We still support 40 MHz bandwidth
things, we just don't use them if we disable HT40.
Or do you mean difference between "hardware capability" and "software
capability" ?
Do you think IEEE80211_HT_CAP_SUP_WIDTH_20_40 bit should be 1 if the
hardware capable of HT40 even though HT40 is disabled by
wpa_supplicant/hostapd ?
I have tested with hostapd. I compared these 2 configfiles.
hostapd0.conf
ht_capab=[HT40-]
hostapd1.conf
#ht_capab=[HT40-]
The IEEE80211_HT_CAP_SUP_WIDTH_20_40 bit in beacon was below.
hostapd0.conf
IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 1
hostapd1.conf
IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 0
So I think the bit should be zero if disabled also for mesh peer.
Masashi Honma.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html