[PATCH] silence warnings when building kernel/bpf/core.c with W=1

Subsystems: bpf [general] (safe dynamic programs and tools), the rest

STALE3668d

2 messages, 2 authors, 2016-08-01 · open the first message on its own page

[PATCH] silence warnings when building kernel/bpf/core.c with W=1

From: Valdis Kletnieks <hidden>
Date: 2016-08-01 03:27:52

Building with W=1 generates some 350 lines of warnings of the form:

kernel/bpf/core.c: In function '__bpf_prog_run':
kernel/bpf/core.c:476:33: warning: initialized field overwritten [-Woverride-init]
   [BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
                                 ^~
kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]')

Since they come from the way we intentionally build the table, silence
that one specific warning.

Signed-off-by: Valdis Kletnieks <redacted>
diff --git a/kernel/bpf/Makefile b/kernel/bpf/Makefile
index eed911d091da..bb915f9d9f92 100644
--- a/kernel/bpf/Makefile
+++ b/kernel/bpf/Makefile
@@ -1,3 +1,4 @@
+CFLAGS_core.o += -Wno-override-init
 obj-y := core.o
 
 obj-$(CONFIG_BPF_SYSCALL) += syscall.o verifier.o inode.o helpers.o

Re: [PATCH] silence warnings when building kernel/bpf/core.c with W=1

From: David Miller <davem@davemloft.net>
Date: 2016-08-01 03:35:23

From: Valdis Kletnieks <redacted>
Date: Sun, 31 Jul 2016 23:27:33 -0400
Building with W=1 generates some 350 lines of warnings of the form:

kernel/bpf/core.c: In function '__bpf_prog_run':
kernel/bpf/core.c:476:33: warning: initialized field overwritten [-Woverride-init]
   [BPF_ALU | BPF_ADD | BPF_X] = &&ALU_ADD_X,
                                 ^~
kernel/bpf/core.c:476:33: note: (near initialization for 'jumptable[12]')

Since they come from the way we intentionally build the table, silence
that one specific warning.

Signed-off-by: Valdis Kletnieks <redacted>
Patch submission must use a proper subsystem prefix in their Subject lines,
as this ends up in the kernel commit shortlog.

The appropriate subsystem prefix for this patch is "bpf: "
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help