[PATCH -next] tipc: fix the error handling in tipc_udp_enable()

Subsystems: networking [general], the rest, tipc network layer

STALE3643d

2 messages, 2 authors, 2016-08-25 · open the first message on its own page

[PATCH -next] tipc: fix the error handling in tipc_udp_enable()

From: Wei Yongjun <hidden>
Date: 2016-08-24 13:32:47

From: Wei Yongjun <redacted>

Fix to return a negative error code in enable_mcast() error handling
case, and release udp socket when necessary.

Fixes: d0f91938bede ("tipc: add ip/udp media type")
Signed-off-by: Wei Yongjun <redacted>
---
 net/tipc/udp_media.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/tipc/udp_media.c b/net/tipc/udp_media.c
index 33bdf54..453ab0b 100644
--- a/net/tipc/udp_media.c
+++ b/net/tipc/udp_media.c
@@ -396,10 +396,13 @@ static int tipc_udp_enable(struct net *net, struct tipc_bearer *b,
 	tuncfg.encap_destroy = NULL;
 	setup_udp_tunnel_sock(net, ub->ubsock, &tuncfg);
 
-	if (enable_mcast(ub, remote))
+	err = enable_mcast(ub, remote);
+	if (err)
 		goto err;
 	return 0;
 err:
+	if (ub->ubsock)
+		udp_tunnel_sock_release(ub->ubsock);
 	kfree(ub);
 	return err;
 }

Re: [PATCH -next] tipc: fix the error handling in tipc_udp_enable()

From: David Miller <hidden>
Date: 2016-08-25 23:43:43

From: Wei Yongjun <redacted>
Date: Wed, 24 Aug 2016 13:32:19 +0000
From: Wei Yongjun <redacted>

Fix to return a negative error code in enable_mcast() error handling
case, and release udp socket when necessary.

Fixes: d0f91938bede ("tipc: add ip/udp media type")
Signed-off-by: Wei Yongjun <redacted>
Since this bug exists in mainline I applied this patch to 'net'.

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help