[PATCH -next] ixgbe: Fix non static symbol warnings

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE3675d

2 messages, 2 authors, 2016-08-23 · open the first message on its own page

[PATCH -next] ixgbe: Fix non static symbol warnings

From: Wei Yongjun <hidden>
Date: 2016-08-23 15:07:59

From: Wei Yongjun <redacted>

Fixes the following sparse warnings:

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning:
 symbol 'ixgbe_led_on_t_x550em' was not declared. Should it be static?
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning:
 symbol 'ixgbe_led_off_t_x550em' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
index fb1b819..417913e 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c
@@ -2125,7 +2125,7 @@ static s32 ixgbe_reset_phy_t_X550em(struct ixgbe_hw *hw)
  *  @hw: pointer to hardware structure
  *  @led_idx: led number to turn on
  **/
-s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
+static s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
 {
 	u16 phy_data;
 
@@ -2147,7 +2147,7 @@ s32 ixgbe_led_on_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
  *  @hw: pointer to hardware structure
  *  @led_idx: led number to turn off
  **/
-s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
+static s32 ixgbe_led_off_t_x550em(struct ixgbe_hw *hw, u32 led_idx)
 {
 	u16 phy_data;
 

RE: [Intel-wired-lan] [PATCH -next] ixgbe: Fix non static symbol warnings

From: Tantilov, Emil S <hidden>
Date: 2016-08-23 17:18:08

-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
Behalf Of Wei Yongjun
Sent: Tuesday, August 23, 2016 8:07 AM
To: Kirsher, Jeffrey T <redacted>
Cc: intel-wired-lan@lists.osuosl.org; Wei Yongjun <redacted>;
netdev@vger.kernel.org
Subject: [Intel-wired-lan] [PATCH -next] ixgbe: Fix non static symbol
warnings

From: Wei Yongjun <redacted>

Fixes the following sparse warnings:

drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2128:5: warning:
symbol 'ixgbe_led_on_t_x550em' was not declared. Should it be static?
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c:2150:5: warning:
symbol 'ixgbe_led_off_t_x550em' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <redacted>
Already resolved:
http://patchwork.ozlabs.org/patch/661647/

Thanks,
Emil
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help