# \[PATCH 02/20\] batman-adv: Place kref\_get for orig\_ifinfo near use

- From: Simon Wunderlich \<hidden\>
- Date: 2016-08-22 13:56:02 
- List: netdev
- Page: https://ratatoskr.run/netdev/2016/08/11026252
- Thread: https://ratatoskr.run/batman/2016/08/11026252/t.md

```text
From: Sven Eckelmann <redacted>

It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.

Signed-off-by: Sven Eckelmann <redacted>
Signed-off-by: Marek Lindner <redacted>
Signed-off-by: Simon Wunderlich <redacted>
---
 net/batman-adv/originator.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c
index 5108af1..8828964 100644
--- a/net/batman-adv/originator.c
+++ b/net/batman-adv/originator.c
@@ -386,6 +386,7 @@ batadv_orig_ifinfo_new(struct batadv_orig_node *orig_node,
 	orig_ifinfo->if_outgoing = if_outgoing;
 	INIT_HLIST_NODE(&orig_ifinfo->list);
 	kref_init(&orig_ifinfo->refcount);
+
 	kref_get(&orig_ifinfo->refcount);
 	hlist_add_head_rcu(&orig_ifinfo->list,
 			   &orig_node->ifinfo_list);
-- 
2.9.3
```