[PATCH net] sit: ipip6_valid_ip_proto() is static

Subsystems: networking [general], the rest

STALE3650d

2 messages, 2 authors, 2016-08-20 · open the first message on its own page

[PATCH net] sit: ipip6_valid_ip_proto() is static

From: Eric Dumazet <hidden>
Date: 2016-08-19 02:25:54

From: Eric Dumazet <edumazet@google.com>

Fixes this sparse error :
net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not
declared. Should it be static?


Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4")
Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 net/ipv6/sit.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index 182b6a9be29d..d6da9febb12d 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -1126,7 +1126,7 @@ static int ipip6_tunnel_update_6rd(struct ip_tunnel *t,
 }
 #endif
 
-bool ipip6_valid_ip_proto(u8 ipproto)
+static bool ipip6_valid_ip_proto(u8 ipproto)
 {
 	return ipproto == IPPROTO_IPV6 ||
 		ipproto == IPPROTO_IPIP ||

Re: [PATCH net] sit: ipip6_valid_ip_proto() is static

From: David Miller <davem@davemloft.net>
Date: 2016-08-20 00:08:35

From: Eric Dumazet <redacted>
Date: Thu, 18 Aug 2016 10:03:55 -0700
From: Eric Dumazet <edumazet@google.com>

Fixes this sparse error :
net/ipv6/sit.c:1129:6: warning: symbol 'ipip6_valid_ip_proto' was not
declared. Should it be static?


Fixes: 49dbe7ae2168b ("sit: support MPLS over IPv4")
Signed-off-by: Eric Dumazet <edumazet@google.com>
This was done in net-next already.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help