[PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

Subsystems: the rest

STALE3646d

4 messages, 2 authors, 2016-08-22 · open the first message on its own page

[PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

From: Eric Dumazet <hidden>
Date: 2016-08-17 21:39:23

From: Eric Dumazet <edumazet@google.com>

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet <edumazet@google.com>
---
 ip/ipaddress.c |    8 ++++++++
 1 file changed, 8 insertions(+)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index ab4b1b1..76bd7b3 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -901,6 +901,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
 			fprintf(fp, "numrxqueues %u ",
 				rta_getattr_u32(tb[IFLA_NUM_RX_QUEUES]));
 
+		if (tb[IFLA_GSO_MAX_SIZE])
+			fprintf(fp, "gso_max_size %u ",
+				rta_getattr_u32(tb[IFLA_GSO_MAX_SIZE]));
+
+		if (tb[IFLA_GSO_MAX_SEGS])
+			fprintf(fp, "gso_max_segs %u ",
+				rta_getattr_u32(tb[IFLA_GSO_MAX_SEGS]));
+
 		if (tb[IFLA_PHYS_PORT_NAME])
 			fprintf(fp, "portname %s ",
 				rta_getattr_str(tb[IFLA_PHYS_PORT_NAME]));

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

From: Eric Dumazet <hidden>
Date: 2016-08-19 02:32:14

On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
On Wed, 17 Aug 2016 14:39:21 -0700
Eric Dumazet [off-list ref] wrote:
quoted
From: Eric Dumazet <edumazet@google.com>

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet <edumazet@google.com>

What about setting them?
This is not something the kernel does at this moment.

Drivers usually set a value, depending on hardware or software
constraints.

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-08-19 03:01:20

On Wed, 17 Aug 2016 14:39:21 -0700
Eric Dumazet [off-list ref] wrote:
From: Eric Dumazet <edumazet@google.com>

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet <edumazet@google.com>

What about setting them?

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-08-22 17:04:26

On Thu, 18 Aug 2016 15:14:38 -0700
Eric Dumazet [off-list ref] wrote:
On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
quoted
On Wed, 17 Aug 2016 14:39:21 -0700
Eric Dumazet [off-list ref] wrote:
  
quoted
From: Eric Dumazet <edumazet@google.com>

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet <edumazet@google.com>  

What about setting them?  
This is not something the kernel does at this moment.

Drivers usually set a value, depending on hardware or software
constraints.

Ok, applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help