[PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier

Subsystems: the rest

STALE3649d

3 messages, 2 authors, 2016-08-22 · open the first message on its own page

[PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2016-08-17 11:17:14

From: Jamal Hadi Salim <jhs@mojatatu.com>

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/f_tcindex.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tc/f_tcindex.c b/tc/f_tcindex.c
index 280d1d4..0a73784 100644
--- a/tc/f_tcindex.c
+++ b/tc/f_tcindex.c
@@ -99,7 +99,7 @@ static int tcindex_parse_opt(struct filter_util *qu, char *handle, int argc,
 			continue;
 		} else if (!strcmp(*argv,"action")) {
 			NEXT_ARG();
-			if (parse_police(&argc, &argv, TCA_TCINDEX_ACT, n)) {
+			if (parse_action(&argc, &argv, TCA_TCINDEX_ACT, n)) {
 				fprintf(stderr, "Illegal \"action\"\n");
 				return -1;
 			}
-- 
1.9.1

Re: [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2016-08-19 03:30:26

On Wed, 17 Aug 2016 07:16:53 -0400
Jamal Hadi Salim [off-list ref] wrote:
From: Jamal Hadi Salim <jhs@mojatatu.com>

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
The is ok for the parsing of config, but you are still using print_police
for display.

Re: [PATCH iproute2 1/1] tc classifiers: Modernize tcindex classifier

From: Jamal Hadi Salim <jhs@mojatatu.com>
Date: 2016-08-22 11:12:41

On 16-08-18 05:57 PM, Stephen Hemminger wrote:
The is ok for the parsing of config, but you are still using print_police
for display.
Thanks for catching that. I will send a v2.

cheers,
jamal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help