[PATCH -next] net: ena: Fix error return code in ena_device_init()

Subsystems: amazon ethernet drivers, networking drivers, the rest

STALE3681d

2 messages, 2 authors, 2016-08-15 · open the first message on its own page

[PATCH -next] net: ena: Fix error return code in ena_device_init()

From: Wei Yongjun <hidden>
Date: 2016-08-15 22:51:13

Fix to return a negative error code from the invalid dma width
error handling case instead of 0.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 94790df..4cbe014 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2329,6 +2329,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev,
 	dma_width = ena_com_get_dma_width(ena_dev);
 	if (dma_width < 0) {
 		dev_err(dev, "Invalid dma width value %d", dma_width);
+		rc = dma_width;
 		goto err_mmio_read_less;
 	}

Re: [PATCH -next] net: ena: Fix error return code in ena_device_init()

From: David Miller <davem@davemloft.net>
Date: 2016-08-15 23:34:59

From: Wei Yongjun <redacted>
Date: Mon, 15 Aug 2016 22:51:04 +0000
Fix to return a negative error code from the invalid dma width
error handling case instead of 0.

Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help