[PATCH -next] net: macb: add missing free_netdev() on error in macb_probe()

Subsystems: atmel macb ethernet driver, networking drivers, the rest

STALE3655d

2 messages, 2 authors, 2016-08-15 · open the first message on its own page

[PATCH -next] net: macb: add missing free_netdev() on error in macb_probe()

From: Wei Yongjun <hidden>
Date: 2016-08-12 15:44:01

Add the missing free_netdev() before return from function macb_probe()
in the platform_get_irq() error handling case.

Fixes: c69618b3e4f2 ("net/macb: fix probe sequence to setup clocks earlier")
Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/cadence/macb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
index 6b797e3..dbce938 100644
--- a/drivers/net/ethernet/cadence/macb.c
+++ b/drivers/net/ethernet/cadence/macb.c
@@ -2985,7 +2985,7 @@ static int macb_probe(struct platform_device *pdev)
 	dev->irq = platform_get_irq(pdev, 0);
 	if (dev->irq < 0) {
 		err = dev->irq;
-		goto err_disable_clocks;
+		goto err_out_free_netdev;
 	}
 
 	mac = of_get_mac_address(np);

Re: [PATCH -next] net: macb: add missing free_netdev() on error in macb_probe()

From: David Miller <davem@davemloft.net>
Date: 2016-08-15 04:24:05

From: Wei Yongjun <redacted>
Date: Fri, 12 Aug 2016 15:43:54 +0000
Add the missing free_netdev() before return from function macb_probe()
in the platform_get_irq() error handling case.

Fixes: c69618b3e4f2 ("net/macb: fix probe sequence to setup clocks earlier")
Signed-off-by: Wei Yongjun <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help