[PATCH -next] qed: Fix error return code in qed_resc_alloc()

Subsystems: networking drivers, qlogic ql4xxx ethernet driver, the rest

STALE3669d

2 messages, 2 authors, 2016-08-02 · open the first message on its own page

[PATCH -next] qed: Fix error return code in qed_resc_alloc()

From: Wei Yongjun <hidden>
Date: 2016-08-02 01:14:30

Fix to return error code -EINVAL instead of 0 when EQ elements is
too larger, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/net/ethernet/qlogic/qed/qed_dev.c | 1 +
 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_dev.c b/drivers/net/ethernet/qlogic/qed/qed_dev.c
index 1a53c04..648c814 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_dev.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_dev.c
@@ -509,6 +509,7 @@ int qed_resc_alloc(struct qed_dev *cdev)
 			DP_ERR(p_hwfn,
 			       "Cannot allocate 0x%x EQ elements. The maximum of a u16 chain is 0x%x\n",
 			       n_eqes, 0xFFFF);
+			rc = -EINVAL;
 			goto alloc_err;
 		}

Re: [PATCH -next] qed: Fix error return code in qed_resc_alloc()

From: David Miller <davem@davemloft.net>
Date: 2016-08-02 04:38:56

From: Wei Yongjun <redacted>
Date: Tue,  2 Aug 2016 00:55:34 +0000
Fix to return error code -EINVAL instead of 0 when EQ elements is
too larger, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <redacted>
Applied, thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help