[PATCH net-next 10/10] Documentation: dtb: xgene: Add rxlos GPIO mapping

Subsystems: networking drivers, open firmware and flattened device tree bindings, the rest

STALE3662d REVIEWED: 1 (0M)

1 review trailer.

3 messages, 3 authors, 2016-08-02 · open the first message on its own page

[PATCH net-next 10/10] Documentation: dtb: xgene: Add rxlos GPIO mapping

From: Iyappan Subramanian <hidden>
Date: 2016-07-30 00:34:03

Signed-off-by: Quan Nguyen <redacted>
Signed-off-by: Iyappan Subramanian <redacted>
Tested-by: Fushen Chen <redacted>
---
 Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
index 05f705e3..b83ae67 100644
--- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
+++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
@@ -24,6 +24,7 @@ Required properties for all the ethernet interfaces:
 - clocks: Reference to the clock entry.
 - local-mac-address: MAC address assigned to this device
 - phy-connection-type: Interface type between ethernet device and PHY device
+- rxlos-gpios: rxlos GPIO mapping
 
 Required properties for ethernet interfaces that have external PHY:
 - phy-handle: Reference to a PHY node connected to this device
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next 10/10] Documentation: dtb: xgene: Add rxlos GPIO mapping

From: Rob Herring <robh@kernel.org>
Date: 2016-08-01 16:35:25

On Fri, Jul 29, 2016 at 05:34:03PM -0700, Iyappan Subramanian wrote:
quoted hunk
Signed-off-by: Quan Nguyen <redacted>
Signed-off-by: Iyappan Subramanian <redacted>
Tested-by: Fushen Chen <redacted>
---
 Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
index 05f705e3..b83ae67 100644
--- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
+++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
@@ -24,6 +24,7 @@ Required properties for all the ethernet interfaces:
 - clocks: Reference to the clock entry.
 - local-mac-address: MAC address assigned to this device
 - phy-connection-type: Interface type between ethernet device and PHY device
+- rxlos-gpios: rxlos GPIO mapping
Needs a vendor prefix and some definition of what rxlos is. Direction 
and active state is needed as well.

Rob

Re: [PATCH net-next 10/10] Documentation: dtb: xgene: Add rxlos GPIO mapping

From: Quan Nguyen <hidden>
Date: 2016-08-02 06:03:01

On Mon, Aug 1, 2016 at 11:35 PM, Rob Herring [off-list ref] wrote:
On Fri, Jul 29, 2016 at 05:34:03PM -0700, Iyappan Subramanian wrote:
quoted
Signed-off-by: Quan Nguyen <redacted>
Signed-off-by: Iyappan Subramanian <redacted>
Tested-by: Fushen Chen <redacted>
---
 Documentation/devicetree/bindings/net/apm-xgene-enet.txt | 1 +
 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
index 05f705e3..b83ae67 100644
--- a/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
+++ b/Documentation/devicetree/bindings/net/apm-xgene-enet.txt
@@ -24,6 +24,7 @@ Required properties for all the ethernet interfaces:
 - clocks: Reference to the clock entry.
 - local-mac-address: MAC address assigned to this device
 - phy-connection-type: Interface type between ethernet device and PHY device
+- rxlos-gpios: rxlos GPIO mapping
Needs a vendor prefix and some definition of what rxlos is. Direction
and active state is needed as well.
Hi Rob,

This gpio signal is from SFP+ module which will tell whether incoming
fiber signal available. As this is gpio, it must have the form of
"xxxx-gpios" as stated in Documentation/gpio/board.txt. As per this
document, the active state is also included in this property.

About definition for "rxlos-gpios", I suggested as below :
"- rxlos-gpios: Optional, input gpio from SFP+ module to indicate
availability of incoming signal"

Thank you,
Quan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help