[PATCH 1/1] net: e1000: do not use uninitalized variable.

Subsystems: intel ethernet drivers, networking drivers, the rest

STALE3690d

2 messages, 2 authors, 2016-08-01 · open the first message on its own page

[PATCH 1/1] net: e1000: do not use uninitalized variable.

From: Heinrich Schuchardt <hidden>
Date: 2016-07-31 09:31:23

phy_data has to be set to zero to avoid undefined
behavior.

Signed-off-by: Heinrich Schuchardt <redacted>
---
 drivers/net/ethernet/intel/e1000/e1000_hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_hw.c b/drivers/net/ethernet/intel/e1000/e1000_hw.c
index 8172cf0..456bb07 100644
--- a/drivers/net/ethernet/intel/e1000/e1000_hw.c
+++ b/drivers/net/ethernet/intel/e1000/e1000_hw.c
@@ -5390,7 +5390,7 @@ static s32 e1000_set_phy_mode(struct e1000_hw *hw)
 static s32 e1000_set_d3_lplu_state(struct e1000_hw *hw, bool active)
 {
 	s32 ret_val;
-	u16 phy_data;
+	u16 phy_data = 0;
 
 	if (hw->phy_type != e1000_phy_igp)
 		return E1000_SUCCESS;
-- 
2.8.1

Re: [PATCH 1/1] net: e1000: do not use uninitalized variable.

From: David Miller <davem@davemloft.net>
Date: 2016-08-01 03:47:46

From: Heinrich Schuchardt <redacted>
Date: Sun, 31 Jul 2016 11:30:58 +0200
phy_data has to be set to zero to avoid undefined
behavior.
In your opinion.

phy_data is only used in conditions where it has been initialized
in this function.

Therefore, please read the function carefully instead of just having
knee jerk reactions to whatever the compiler spits out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help