Re: linux-next: Tree for Jul 13 (net/core/devlink with Tracing)

On 07/12/16 23:47, Stephen Rothwell wrote:

Hi all,

Changes since 20160712:

on x86_64:
(full randconfig file is attached)


  CC      net/core/devlink.o
In file included from ../include/trace/define_trace.h:95:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
../include/trace/events/devlink.h: In function 'trace_event_get_offsets_devlink_hwmsg':
../include/trace/events/devlink.h:25:51: error: dereferencing pointer to incomplete type
   __string(owner_name, devlink->dev->driver->owner->name)
                                                   ^
../include/trace/trace_events.h:501:2: note: in definition of macro 'DECLARE_EVENT_CLASS'
  tstruct;       \
  ^
../include/trace/trace_events.h:63:9: note: in expansion of macro 'PARAMS'
         PARAMS(tstruct),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:22:2: note: in expansion of macro 'TP_STRUCT__entry'
  TP_STRUCT__entry(
  ^
../include/trace/trace_events.h:466:29: note: in expansion of macro '__dynamic_array'
 #define __string(item, src) __dynamic_array(char, item,   \
                             ^
../include/trace/events/devlink.h:25:3: note: in expansion of macro '__string'
   __string(owner_name, devlink->dev->driver->owner->name)
   ^
../include/trace/events/devlink.h:25:51: error: dereferencing pointer to incomplete type
   __string(owner_name, devlink->dev->driver->owner->name)
                                                   ^
../include/trace/trace_events.h:501:2: note: in definition of macro 'DECLARE_EVENT_CLASS'
  tstruct;       \
  ^
../include/trace/trace_events.h:63:9: note: in expansion of macro 'PARAMS'
         PARAMS(tstruct),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:22:2: note: in expansion of macro 'TP_STRUCT__entry'
  TP_STRUCT__entry(
  ^
../include/trace/trace_events.h:466:29: note: in expansion of macro '__dynamic_array'
 #define __string(item, src) __dynamic_array(char, item,   \
                             ^
../include/trace/events/devlink.h:25:3: note: in expansion of macro '__string'
   __string(owner_name, devlink->dev->driver->owner->name)
   ^
In file included from ../include/trace/define_trace.h:95:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
../include/trace/events/devlink.h: In function 'trace_event_raw_event_devlink_hwmsg':
../include/trace/events/devlink.h:35:55: error: dereferencing pointer to incomplete type
   __assign_str(owner_name, devlink->dev->driver->owner->name);
                                                       ^
../include/trace/trace_events.h:686:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }       \
    ^
../include/trace/trace_events.h:64:9: note: in expansion of macro 'PARAMS'
         PARAMS(assign),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:32:2: note: in expansion of macro 'TP_fast_assign'
  TP_fast_assign(
  ^
../include/trace/events/devlink.h:35:3: note: in expansion of macro '__assign_str'
   __assign_str(owner_name, devlink->dev->driver->owner->name);
   ^
../include/trace/events/devlink.h:35:55: error: dereferencing pointer to incomplete type
   __assign_str(owner_name, devlink->dev->driver->owner->name);
                                                       ^
../include/trace/trace_events.h:686:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }       \
    ^
../include/trace/trace_events.h:64:9: note: in expansion of macro 'PARAMS'
         PARAMS(assign),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:32:2: note: in expansion of macro 'TP_fast_assign'
  TP_fast_assign(
  ^
../include/trace/events/devlink.h:35:3: note: in expansion of macro '__assign_str'
   __assign_str(owner_name, devlink->dev->driver->owner->name);
   ^
In file included from ../include/trace/define_trace.h:96:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
../include/trace/events/devlink.h: In function 'perf_trace_devlink_hwmsg':
../include/trace/events/devlink.h:35:55: error: dereferencing pointer to incomplete type
   __assign_str(owner_name, devlink->dev->driver->owner->name);
                                                       ^
../include/trace/perf.h:65:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }       \
    ^
../include/trace/trace_events.h:64:9: note: in expansion of macro 'PARAMS'
         PARAMS(assign),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:32:2: note: in expansion of macro 'TP_fast_assign'
  TP_fast_assign(
  ^
../include/trace/events/devlink.h:35:3: note: in expansion of macro '__assign_str'
   __assign_str(owner_name, devlink->dev->driver->owner->name);
   ^
../include/trace/events/devlink.h:35:55: error: dereferencing pointer to incomplete type
   __assign_str(owner_name, devlink->dev->driver->owner->name);
                                                       ^
../include/trace/perf.h:65:4: note: in definition of macro 'DECLARE_EVENT_CLASS'
  { assign; }       \
    ^
../include/trace/trace_events.h:64:9: note: in expansion of macro 'PARAMS'
         PARAMS(assign),         \
         ^
../include/trace/events/devlink.h:16:1: note: in expansion of macro 'TRACE_EVENT'
 TRACE_EVENT(devlink_hwmsg,
 ^
../include/trace/events/devlink.h:32:2: note: in expansion of macro 'TP_fast_assign'
  TP_fast_assign(
  ^
../include/trace/events/devlink.h:35:3: note: in expansion of macro '__assign_str'
   __assign_str(owner_name, devlink->dev->driver->owner->name);
   ^
../scripts/Makefile.build:289: recipe for target 'net/core/devlink.o' failed




-- 
~Randy

On Wed, 13 Jul 2016 08:12:16 -0700
Randy Dunlap [off-list ref] wrote:

On 07/12/16 23:47, Stephen Rothwell wrote:

quoted

Hi all,

Changes since 20160712:
  

on x86_64:
(full randconfig file is attached)


  CC      net/core/devlink.o
In file included from ../include/trace/define_trace.h:95:0,
                 from ../include/trace/events/devlink.h:51,
                 from ../net/core/devlink.c:30:
../include/trace/events/devlink.h: In function 'trace_event_get_offsets_devlink_hwmsg':
../include/trace/events/devlink.h:25:51: error: dereferencing pointer to incomplete type
   __string(owner_name, devlink->dev->driver->owner->name)

[snip the rest]

When I remove all references to the owner_name (and that crazy
dereferencing above), it compiles fine. There must be something funky
with that devlink->dev->driver->owner->name part.

-- Steve